Add LiveView URL template attribute #431
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
requested review from
bryannaegele and
tsloughter
as code owners
This was referenced Dec 14, 2024
danschultzer
force-pushed
the
add-liveview-route
branch
2 times, most recently
from
6ad0bc2 to
8462da6
Compare
danschultzer
force-pushed
the
add-liveview-route
branch
from
8462da6 to
a8975ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two commits, one that refactors the LiveView test to use something that's closer to how LiveView itself tests sockets, and a second that parses and adds the URL template attribute to match the attribute being added by the router dispatch event.
I can split it into two PRs if that's preferred.
Adds
url.templateto the liveview spans